[Intel-gfx] [PATCH 1/2] drm/i915: Move uncore definitions into a separate header

Michal Wajdeczko michal.wajdeczko at intel.com
Tue May 9 09:12:13 UTC 2017


On Tue, May 09, 2017 at 12:00:58PM +0300, Mika Kuoppala wrote:
> Michal Wajdeczko <michal.wajdeczko at intel.com> writes:
> 
> > In order to allow use of e.g. forcewake_domains in a other feature headers
> > included from the top of i915_drv.h, move all uncore related definitions
> > into their own header.
> >
> > Signed-off-by: Michal Wajdeczko <michal.wajdeczko at intel.com>
> > Suggested-by: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>
> > Cc: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>
> > ---

<snip>

> > -
> > -#define __mask_next_bit(mask) ({					\
> > -	int __idx = ffs(mask) - 1;					\
> > -	mask &= ~BIT(__idx);						\
> > -	__idx;								\
> > -})
> > -
> 
> for_each_engine_masked needs this macro too, so we should leave it to
>  top level or i915_utils.h?

Sure, I'll move it to the i915_utils.h, but at the same time I'm
wondering how did I missed that.

Thanks,
Michal 



More information about the Intel-gfx mailing list