[Intel-gfx] [PATCH 2/2] drm/i915: Rename assert_forcewakes_inactive

Michal Wajdeczko michal.wajdeczko at intel.com
Tue May 9 10:20:39 UTC 2017


On Tue, May 09, 2017 at 11:09:58AM +0100, Chris Wilson wrote:
> On Tue, May 09, 2017 at 07:36:09AM +0000, Michal Wajdeczko wrote:
> > All other functions related to uncore start with intel_uncore prefix.
> > Follow that pattern.
> 
> Debatable. Fwiw, we use the assert_*() pattern frequently because that
> "it's a debug only function" is important to make it the first word.

But most of our assert_*() functions are declared as static, so they don't count.
I think in case of public functions, we should follow object/verb pattern.
Note that there is lockdep_assert_held() not assert_lockdep_held().

-Michal


More information about the Intel-gfx mailing list