[Intel-gfx] [PATCHv2] drm/prime: Forward declare struct device

Sumit Semwal sumit.semwal at linaro.org
Wed May 10 17:13:03 UTC 2017


Hi Laura,

On 10 May 2017 at 22:35, Laura Abbott <labbott at redhat.com> wrote:
>
> We need a declaration of struct device to avoid warnings:
>
> In file included from include/drm/drm_file.h:38:0,
>                  from drivers/gpu/drm/drm_file.c:38:
> include/drm/drm_prime.h:71:14: warning: 'struct device' declared inside
>           parameter list will not be visible outside of this definition or
>           declaration
>           struct device *attach_dev);
>                  ^~~~~~
>
> Forward declare it.
>
> Signed-off-by: Laura Abbott <labbott at redhat.com>
Thanks for the patch; feel free to add my
Reviewed-by: Sumit Semwal <sumit.semwal at linaro.org>

> ---
> v2: Switch to foward declaration instead of including a header.
> ---
>  include/drm/drm_prime.h | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/include/drm/drm_prime.h b/include/drm/drm_prime.h
> index 46fd1fb..59ccab4 100644
> --- a/include/drm/drm_prime.h
> +++ b/include/drm/drm_prime.h
> @@ -50,6 +50,8 @@ struct drm_prime_file_private {
>         struct rb_root handles;
>  };
>
> +struct device;
> +
>  struct dma_buf_export_info;
>  struct dma_buf;
>
> --
> 2.7.4
>

Best,
Sumit.


More information about the Intel-gfx mailing list