[Intel-gfx] [PATCH i-g-t v2 00/13] Fix IGTs for Android\

Arkadiusz Hiler arkadiusz.hiler at intel.com
Thu May 18 11:55:59 UTC 2017


On Thu, May 18, 2017 at 11:09:06AM +0300, Petri Latvala wrote:
> 
> Patches 1-4 and 6-13 are

Send v2 of patch 5 that incorporates Michal's feedback.

> Reviewed-by: Petri Latvala <petri.latvala at intel.com>
> 
> Nitpicks on the commit message on patch 6 (replied to it).

Sent fixed version.

Thanks!

-- 
Cheers,
Arek

> On Tue, May 16, 2017 at 03:24:49PM +0200, Arkadiusz Hiler wrote:
> > IGTs are broken for Android since the introduction of dependency on procps. Over
> > time other incompatibilities built up.
> > 
> > I took the liberty to fix some of the issues, workaround couple of others and
> > blacklist heavily incompatible tools/tests.
> > 
> > It builds on (almost) vanilla AOSP now.
> > 
> > Github: <https://github.com/ivyl/igt/commits/android>
> > Howto:  <https://gist.github.com/ivyl/1e05af15ae37b575e03dc69e5e2488fc>
> >         now including docker exmaple / script for your convenience
> > 
> > DEP1: <https://github.com/ivyl/libkmod-android> - just builds Google's one
> > DEP2: <https://github.com/android-ia/external_libpciaccess>
> > 
> > We should include a note on Android compatibility in the README and do
> > "continuous compilation" of the patches as they arrive on the mailing list,
> > otherwise this **will get broken again soon**.
> > 
> > This is long as it is, but not complete yet.
> > 
> > Here are some of more obvious TODOs:
> >  * introduce something like IGT_HAS_CAIRO define for convenience
> >  * revise igt_kms dependency on cairo and enable everything what is independent
> >  * revise kms tests and do the above
> >  * review all things that are disabled on Android and try to enable them
> >  * do something less ugly with config.h generation on Android
> > 
> > v2: couple of suggested fixed + everything that was not compatible since last
> >     patch
> > 
> > Cc: Petri Latvala <petri.latvala at intel.com>
> > Cc: Antonio Argenziano <antonio.argenziano at intel.com>
> > Cc: Vinay Belgaumkar <vinay.belgaumkar at intel.com>
> > Cc: Chris Wilson <chris at chris-wilson.co.uk>
> > Cc: Robert Foss <robert.foss at collabora.com>
> > 
> > 
> > Arkadiusz Hiler (13):
> >   tests/drm_import_export: Include {i915_,}drm.h properly
> >   Make conditions on HAVE_UDEV consistent
> >   lib/igt_aux: Include unistd.h for gettid() on Android
> >   lib/igt_aux: Make procps optional
> >   chamelium: Fix build issues on Android
> >   tools/Android.mk: Add guc_logger and l3_parity skip list
> >   tests/Android.mk: Add perf to skip list
> >   Android.mk: Fix libkmod use
> >   Android.mk: Filter out *.h from src files
> >   Android.mk: Use drm stubs
> >   tools/Android.mk: Fix zlib inclusion
> >   tests/gem_exec_nop: Disable headless subtest on cairoless Android
> >   tests/gem_exec_nop: Rename signal() to fence_signal()
> > 
> >  benchmarks/Android.mk          |  5 ++++-
> >  configure.ac                   |  6 +++++-
> >  demos/Android.mk               |  3 ++-
> >  lib/Android.mk                 |  7 ++++---
> >  lib/Makefile.am                |  7 +++++++
> >  lib/Makefile.sources           |  7 -------
> >  lib/igt.h                      |  2 ++
> >  lib/igt_aux.c                  | 37 +++++++++++++++++++++++++++++++++----
> >  lib/igt_aux.h                  |  5 +++++
> >  lib/igt_chamelium.h            |  3 +++
> >  lib/igt_kmod.h                 |  4 ++++
> >  lib/tests/Android.mk           |  4 ++--
> >  tests/Android.mk               |  9 +++++----
> >  tests/Makefile.am              |  6 ++++++
> >  tests/Makefile.sources         |  6 ------
> >  tests/drm_import_export.c      |  4 ++--
> >  tests/gem_exec_nop.c           | 14 +++++++++-----
> >  tests/testdisplay_hotplug.c    |  2 +-
> >  tools/Android.mk               | 14 +++++++++-----
> >  tools/intel_l3_parity.c        |  2 +-
> >  tools/intel_l3_parity.h        |  2 +-
> >  tools/intel_l3_udev_listener.c |  2 +-
> >  22 files changed, 106 insertions(+), 45 deletions(-)
> > 
> > -- 
> > 2.9.3
> > 


More information about the Intel-gfx mailing list