[Intel-gfx] [PATCH v2] drm/i915/gvt: disable GVT-g if host GuC submission is enabled

[Dong, Chuanxiao]

> -----Original Message-----
> From: Joonas Lahtinen [mailto:joonas.lahtinen at linux.intel.com]
> Sent: Thursday, May 18, 2017 6:37 PM
> To: Dong, Chuanxiao <chuanxiao.dong at intel.com>; intel-gvt-
> dev at lists.freedesktop.org; intel-gfx at lists.freedesktop.org
> Subject: Re: [Intel-gfx] [PATCH v2] drm/i915/gvt: disable GVT-g if host GuC
> submission is enabled
> 
> On ti, 2017-05-16 at 07:53 +0000, Dong, Chuanxiao wrote:
> > >
> > > Thanks Joonas. If to fail with -EIO, how about for the other two
> > > checks: " if (!is_supported_device(dev_priv))" and " if
> (!i915.enable_execlists)"?
> > > Currently these two cases are failed with 0 instead of -EIO. Looks
> > > like should also fail with -EIO?
> 
> !is_supported_device check should probably be done in parameter
> sanitization phase, it should not result in EIO, because enable_gvt is not
> marked as an unsafe option.
> 
> enable_execlists on the other hand is a an _unsafe option and should result
> in -EIO.
> 
Thanks Joonas for the suggestion. Looks like we need two more patches here, one for add a sanitize API for GVT so it can be called by intel_sanitize_options in sanitization phase. Another patch is to return -EIO if !i915.enable_execlists. Will send out these two patches first.

Thanks
Chuanxiao