[Intel-gfx] [PATCH 00/37] drm: more doc work&cleanup, mostly vblank related

Daniel Vetter daniel.vetter at ffwll.ch
Wed May 24 14:51:35 UTC 2017


Hi all,

So the first part of this patch series is the usual deal of decrufting some part
of drm and attempting to improve the docs. Mostly around vblank. I seem to be
the ever constant 5% of finally being able to document drm_driver/device
properly, oh well.

By patch count the bigger part is trying to get rid of drm_vblank_cleanup. That
was initially exported to drivers for a radeon ums irq failover hack, and then
seems to have been cargo-culted all over the place. It's a bit of churn, but it
will get us one step closer to tracking vblanks as part of drm_crtc. The other
bit would be to get rid of drm_vblank_init, and instead auto-setup the relevant
vblank stuff in drm_crtc_init (iff the driver supports vblanks ofc).

I'd also like to cleanup the vblank locking a bit, I think switching to per-pipe
locks from the current nested scheme will be both easier to understand and more
concurrent than what we have right now.

Anyway, stuff was getting out of hand so want to flush this out.

Review, comments and testing very much welcome.

Thanks, Daniel

Daniel Vetter (37):
  drm/doc: move printf helpers out of drmP.h
  drm: Remove drm_device->virtdev
  drm/udl: Remove dummy busid callback
  drm: Remove drm_driver->set_busid hook
  drm/pci: Deprecate drm_pci_init/exit completely
  drm/doc: Improve ioctl/fops docs a bit more
  drm: Extract drm_vblank.[hc]
  drm/doc: Polish irq helper documentation
  drm/doc: Drop empty include for drm_color_mgmt.h
  drm/doc: vblank cleanup
  drm/vblank: _ioctl posfix for ioctl handler
  drm/vblank: Consistent drm_crtc_ prefix
  drm: better document how to send out the crtc disable event
  drm/amd|radeon: Drop drm_vblank_cleanup
  drm/arcgpu: Drop drm_vblank_cleanup
  drm/hdlcd|mali: Drop drm_vblank_cleanup
  drm/atmel: Drop drm_vblank_cleanup
  drm/exynos: Drop drm_vblank_cleanup
  drm/fsl: Drop drm_vblank_cleanup
  drm/hibmc: Drop drm_vblank_cleanup
  drm/kirin: Drop drm_vblank_cleanup
  drm/i915: Drop drm_vblank_cleanup
  drm/imx: Drop drm_vblank_cleanup
  drm/mtk: Drop drm_vblank_cleanup
  drm/meson: Drop drm_vblank_cleanup
  drm/mxsfb: Drop drm_vblank_cleanup
  drm/nouveau: Drop drm_vblank_cleanup
  drm/rockchip: Drop drm_vblank_cleanup
  drm/shmob: Drop drm_vblank_cleanup
  drm/sti: Drop drm_vblank_cleanup
  drm/stm: Drop drm_vblank_cleanup
  drm/sun4i: Drop drm_vblank_cleanup
  drm/tegra: Drop drm_vblank_cleanup
  drm/udl: Drop drm_vblank_cleanup
  drm/vmwgfx: Drop drm_vblank_cleanup
  drm/zte: Drop drm_vblank_cleanup
  drm/vblank: Unexport drm_vblank_cleanup

 Documentation/gpu/drm-internals.rst             |   64 +-
 Documentation/gpu/drm-kms.rst                   |   63 +-
 Documentation/gpu/drm-uapi.rst                  |    2 +
 drivers/gpu/drm/Makefile                        |    2 +-
 drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c         |    5 +-
 drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c         |    1 -
 drivers/gpu/drm/arc/arcpgu_drv.c                |    1 -
 drivers/gpu/drm/arm/hdlcd_drv.c                 |    2 -
 drivers/gpu/drm/arm/malidp_drv.c                |    2 -
 drivers/gpu/drm/ast/ast_drv.c                   |    5 +-
 drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c    |    1 -
 drivers/gpu/drm/bochs/bochs_drv.c               |    5 +-
 drivers/gpu/drm/cirrus/cirrus_drv.c             |    5 +-
 drivers/gpu/drm/drm_file.c                      |    7 +-
 drivers/gpu/drm/drm_internal.h                  |   17 +-
 drivers/gpu/drm/drm_ioctl.c                     |   13 +-
 drivers/gpu/drm/drm_irq.c                       | 1643 +----------------------
 drivers/gpu/drm/drm_pci.c                       |   40 +-
 drivers/gpu/drm/drm_vblank.c                    | 1611 ++++++++++++++++++++++
 drivers/gpu/drm/exynos/exynos_drm_drv.c         |    4 +-
 drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c       |    2 -
 drivers/gpu/drm/gma500/psb_drv.c                |    5 +-
 drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c |    3 +-
 drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c |    1 -
 drivers/gpu/drm/i810/i810_drv.c                 |    5 +-
 drivers/gpu/drm/i915/i915_drv.c                 |    7 +-
 drivers/gpu/drm/i915/i915_irq.c                 |    2 +-
 drivers/gpu/drm/i915/intel_display.c            |    2 +-
 drivers/gpu/drm/imx/imx-drm-core.c              |    4 +-
 drivers/gpu/drm/mediatek/mtk_drm_drv.c          |    1 -
 drivers/gpu/drm/meson/meson_drv.c               |    1 -
 drivers/gpu/drm/mga/mga_drv.c                   |    5 +-
 drivers/gpu/drm/mgag200/mgag200_drv.c           |    6 +-
 drivers/gpu/drm/mxsfb/mxsfb_drv.c               |    1 -
 drivers/gpu/drm/nouveau/nouveau_display.c       |    2 -
 drivers/gpu/drm/nouveau/nouveau_drm.c           |   12 +-
 drivers/gpu/drm/nouveau/nv50_display.c          |    2 +-
 drivers/gpu/drm/qxl/qxl_drv.c                   |    6 +-
 drivers/gpu/drm/r128/r128_drv.c                 |    5 +-
 drivers/gpu/drm/radeon/radeon_drv.c             |    6 +-
 drivers/gpu/drm/radeon/radeon_irq_kms.c         |    1 -
 drivers/gpu/drm/rockchip/rockchip_drm_drv.c     |    2 -
 drivers/gpu/drm/savage/savage_drv.c             |    5 +-
 drivers/gpu/drm/shmobile/shmob_drm_drv.c        |    4 +-
 drivers/gpu/drm/sis/sis_drv.c                   |    5 +-
 drivers/gpu/drm/sti/sti_drv.c                   |    1 -
 drivers/gpu/drm/stm/ltdc.c                      |    2 -
 drivers/gpu/drm/sun4i/sun4i_drv.c               |    2 -
 drivers/gpu/drm/tdfx/tdfx_drv.c                 |    5 +-
 drivers/gpu/drm/tegra/drm.c                     |    5 +-
 drivers/gpu/drm/udl/udl_drv.c                   |    6 -
 drivers/gpu/drm/udl/udl_main.c                  |    2 -
 drivers/gpu/drm/via/via_drv.c                   |    5 +-
 drivers/gpu/drm/virtio/virtgpu_drm_bus.c        |    1 -
 drivers/gpu/drm/virtio/virtgpu_kms.c            |    4 +-
 drivers/gpu/drm/vmwgfx/vmwgfx_drv.c             |    5 +-
 drivers/gpu/drm/vmwgfx/vmwgfx_kms.c             |    9 +-
 drivers/gpu/drm/vmwgfx/vmwgfx_kms.h             |    2 -
 drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c             |    4 -
 drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c            |    9 -
 drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c            |   27 +-
 drivers/gpu/drm/zte/zx_drm_drv.c                |    2 -
 include/drm/drmP.h                              |   70 +-
 include/drm/drm_crtc.h                          |    7 +-
 include/drm/drm_drv.h                           |   53 +-
 include/drm/drm_file.h                          |    1 +
 include/drm/drm_irq.h                           |  158 +--
 include/drm/drm_modes.h                         |   17 +
 include/drm/drm_pci.h                           |   11 +-
 include/drm/drm_prime.h                         |    2 +
 include/drm/drm_rect.h                          |   27 +
 include/drm/drm_vblank.h                        |  180 +++
 72 files changed, 2093 insertions(+), 2112 deletions(-)
 create mode 100644 drivers/gpu/drm/drm_vblank.c
 create mode 100644 include/drm/drm_vblank.h

-- 
2.11.0



More information about the Intel-gfx mailing list