[Intel-gfx] [PATCH v2] drm/i915/selftests: Silence compiler warning in igt_ctx_exec

Joonas Lahtinen joonas.lahtinen at linux.intel.com
Wed May 24 15:49:18 UTC 2017


On ke, 2017-05-24 at 16:37 +0100, Chris Wilson wrote:
> On Wed, May 24, 2017 at 06:24:06PM +0300, Joonas Lahtinen wrote:
> > 
> > On ti, 2017-05-23 at 20:44 +0100, Chris Wilson wrote:
> > > 
> > > The compiler doesn't always spot the guard that object is allocated on
> > > the first pass, leading to:
> > > 
> > > drivers/gpu/drm/i915/selftests/i915_gem_context.c: warning: 'obj' may be used uninitialized in this function [-Wuninitialized]:  => 370:8
> > > 
> > > v2: Make it more obvious by setting obj to NULL on the first pass and
> > > any later pass where we need to reallocate.
> > > 
> > > Reported-by: Geert Uytterhoeven <geert at linux-m68k.org>
> > > Fixes: 791ff39ae32a ("drm/i915: Live testing for context execution")
> > > Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> > > Cc: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>
> > > Cc: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
> > > Cc: Matthew Auld <matthew.auld at intel.com>
> > > c: <drm-intel-fixes at lists.freedesktop.org> # v4.12-rc1+
> > 
> > Still not Cc?
> 
> :( Completely forgot. Still debatable if we care whether the build
> report is improved for v4.12 or v4.13.

I don't think it's worth backporting.

Regards, Joonas
-- 
Joonas Lahtinen
Open Source Technology Center
Intel Corporation


More information about the Intel-gfx mailing list