[Intel-gfx] [PATCH v6] drm/i915/guc: capture GuC logs if FW fails to load

[Chris Wilson]

On Thu, May 25, 2017 at 11:58:25AM -0700, Michel Thierry wrote:
> On 25/05/17 08:31, Daniele Ceraolo Spurio wrote:
> >
> >
> >On 22/05/17 12:56, Michal Wajdeczko wrote:
> >>On Mon, May 22, 2017 at 10:50:28AM -0700, Daniele Ceraolo Spurio wrote:
> >>>We're currently deleting the GuC logs if the FW fails to load, but those
> >>>are still useful to understand why the loading failed. Keeping the
> >>>object around allows us to access them after driver load is completed.
> >>>
> >>>v2: keep the object around instead of using kernel memory (chris)
> >>>    don't store the logs in the gpu_error struct (Chris)
> >>>    add a check on guc_log_level to avoid snapshotting empty logs
> >>>
> >>>v3: use separate debugfs for error log (Chris)
> >>>
> >>>v4: rebased
> >>>
> >>>v5: clean up obj selection, move err_load inside guc_log, move err_load
> >>>    cleanup, rename functions (Michal)
> >>>
> >>>v6: move obj back to intel_guc, move functions to intel_uc.c, don't
> >>>    clear obj on new GuC load, free object only if enable_guc_loading
> >>>    is set (Michal)
> >>>
> >>>Cc: Chris Wilson <chris at chris-wilson.co.uk>
> >>>Cc: Oscar Mateo <oscar.mateo at intel.com>
> >>>Cc: Michal Wajdeczko <michal.wajdeczko at intel.com>
> >>>Signed-off-by: Daniele Ceraolo Spurio <daniele.ceraolospurio at intel.com>
> >>>---
> >>
> >>Reviewed-by: Michal Wajdeczko <michal.wajdeczko at intel.com>
> >>
> >>Regards,
> >>Michal
> >>
> >
> >Does anyone else have any concern or can this patch be merged?
> >
> 
> +1 about being merged, and since I've been using this patch you could say,

And done. Thanks for the patch, testing and review.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre