[Intel-gfx] [RFC] drm/i915: Extend PARAMS_FOR_EACH macro with more data

Chris Wilson chris at chris-wilson.co.uk
Fri May 26 15:56:11 UTC 2017


On Fri, May 26, 2017 at 03:44:29PM +0000, Michal Wajdeczko wrote:
> Currently our PARAMS_FOR_EACH macro contains only param type and name.
> We use this macro to define struct members, but later on we initialize
> this struct using handcrafted code, which leads in some cases to use
> mismatched value vs. type. Let's extend our root macro with param
> default value to keep them in sync. Also drop ; from the macro to allow
> more flexible usages.

Completely overlooked the initialization, so that looks to be a good
improvement. You can also add the default value to the printers, and if
possible highlight values that have been changed by the user -- we could
include the unsafe notifier in that as well.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre


More information about the Intel-gfx mailing list