[Intel-gfx] [PATCH 19/37] drm/fsl: Drop drm_vblank_cleanup

[Stefan Agner]

On 2017-05-26 00:00, Daniel Vetter wrote:
> On Thu, May 25, 2017 at 10:18 AM, Stefan Agner <stefan at agner.ch> wrote:
>> On 2017-05-24 07:51, Daniel Vetter wrote:
>>> Again cleanup before irq disabling doesn't really stop the races,
>>> so just drop it. Proper fix would be to put drm_atomic_helper_shutdown
>>> before everything gets cleaned up.
>>
>> Hm, I already use the non-atomic drm_crtc_force_disable_all before, I
>> think that fixed the races I saw.
>>
>> But I guess what you are saying instead of using
>> drm_crtc_force_disable_all I should use drm_atomic_helper_shutdown...?
> 
> Yes. I thought I audited all existing users of the legacy
> force_disable (it won't work correctly for atomic drivers), but
> somehow I missed the one in fsl. See
> 
> commit 18dddadc78c91a91b546acc48506c24f5f840c4f
> Author: Daniel Vetter <daniel.vetter at ffwll.ch>
> Date:   Tue Mar 21 17:41:49 2017 +0100
> 
>     drm/atomic: Introduce drm_atomic_helper_shutdown
> 

Ok, I see.

Since this leads to a change just a few lines above this patch, it has
potential for merge conflict. Can I take this change through my tree?

--
Stefan