[Intel-gfx] [PATCH 1/2] drm/i915: Ignore previous watermarks on ILK if inherited

Maarten Lankhorst maarten.lankhorst at linux.intel.com
Wed Nov 1 17:24:09 UTC 2017


Fixes the following error when fastset is enabled, caught by CI:

[drm:ilk_validate_wm_level.part.8 [i915]] Sprite WM0 too large 56 (max 0)
[drm:ilk_validate_pipe_wm [i915]] LP0 watermark invalid
[drm:intel_crtc_atomic_check [i915]] No valid intermediate pipe watermarks are possible

Triggered on debugfs_test.read_all_entries, but could have been any igt
test depending on ordering.

Signed-off-by: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>
---
 drivers/gpu/drm/i915/intel_pm.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
index a01ec068eba8..05dbeb430e21 100644
--- a/drivers/gpu/drm/i915/intel_pm.c
+++ b/drivers/gpu/drm/i915/intel_pm.c
@@ -3380,6 +3380,7 @@ static int ilk_compute_intermediate_wm(struct drm_device *dev,
 	 */
 	*a = newstate->wm.ilk.optimal;
 	if (!newstate->base.active || intel_state->skip_intermediate_wm ||
+	    oldstate->base.mode.private_flags & I915_MODE_FLAG_INHERITED ||
 	    drm_atomic_crtc_needs_modeset(&newstate->base))
 		return 0;
 
-- 
2.14.1



More information about the Intel-gfx mailing list