[Intel-gfx] [PATCH] drm/i915: silence coverity warning

Ville Syrjälä ville.syrjala at linux.intel.com
Thu Nov 2 13:22:51 UTC 2017


On Thu, Nov 02, 2017 at 12:06:27PM +0000, Chris Wilson wrote:
> Quoting Lionel Landwerlin (2017-11-02 11:41:26)
> > Because dev_priv is 0-ed it's not currently an issue, but since we
> > have dev_priv->perf.oa.test_config.uuid size at uuid + 1, we could
> > just copy the null character and silence this warning.
> 
> It doesn't copy the nul over exactly, to be complete s/strncpy/strlcpy/
> as well.

Or just memcpy(), thugh maybe that'd be more dangerous if the size
gets changed for some reasonn.

-- 
Ville Syrjälä
Intel OTC


More information about the Intel-gfx mailing list