[Intel-gfx] [PATCH] drm/i915/dmc: DMC 1.04 for Kabylake

[Rodrigo Vivi]

On Thu, Nov 02, 2017 at 10:34:37AM +0000, Jani Nikula wrote:
> On Wed, 01 Nov 2017, Anusha Srivatsa <anusha.srivatsa at intel.com> wrote:
> > There is a new version of DMC available for KBL.
> 
> Nobody's going to pull this to linux-firmware if you don't send it to
> the linux-firmware folks...

That's intentional. The idea is to send to linux-firmware only after it
passes our CI. So, prepare already in a way that it is easy to just forward when
that happens.

But what I believe we can change is to send that in the cover-letter of
the series.
So cover-letter with pull-request that CI would get automatically,
all related patches on the series, so right now it could be:
patch 0: pull-request
patch 1: kbl dmc 1.04
patch 2: skl dmc 1.27

> 
> > The release notes mentions:
> > 1. Fix for the issue where DC_STATE was getting enabled even
> > when disabled by driver causing data corruption.
> >
> > Adding the pull request here as an experiment-
> > The following changes since commit bf04291309d3169c0ad3b8db52564235bbd08e30:
> >
> >   WHENCE: Add new qed firmware (2017-10-09 18:03:26 +0100)
> >
> > are available in the git repository at:
> >
> >   https://github.com/anushasr/linux-firmware.git KBL_DMC
> 
> We should have a shared repo for this at freedesktop.org instead of your
> private repo at github.

I had never seen a particularly need for that before, but with
this new process in place I believe it makes tons of sense.
Who could help to setup a repo and right permissions?
Daniel Stone?

> And we should use signed tags for pull requests.

Yes, tags are essencial here. Specially with this process
of sending here first for CI and only after passing CI fwding
that to linux-firmware.git we need to have tags.

Thanks,
Rodrigo.

> 
> BR,
> Jani.
> 
> >
> > for you to fetch changes up to 2f2b42764455856c2ba63d2154b3b2fbb7424236:
> >
> >   linux-firmware: DMC firmware for kabylake v1.04 (2017-11-01 19:22:21 -0700)
> >
> > ----------------------------------------------------------------
> > Anusha Srivatsa (1):
> >       linux-firmware: DMC firmware for kabylake v1.04
> >
> >  WHENCE                   |   4 ++++
> >  i915/kbl_dmc_ver1_04.bin | Bin 0 -> 8840 bytes
> >  2 files changed, 4 insertions(+)
> >  create mode 100644 i915/kbl_dmc_ver1_04.bin
> >
> > Cc: Rodrigo Vivi <rodrigo.vivi at intel.com>
> > Signed-off-by: Anusha Srivatsa <anusha.srivatsa at intel.com>
> > ---
> >  drivers/gpu/drm/i915/intel_csr.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_csr.c b/drivers/gpu/drm/i915/intel_csr.c
> > index 3e1f86d..5842777 100644
> > --- a/drivers/gpu/drm/i915/intel_csr.c
> > +++ b/drivers/gpu/drm/i915/intel_csr.c
> > @@ -40,9 +40,9 @@
> >  #define I915_CSR_CNL "i915/cnl_dmc_ver1_06.bin"
> >  #define CNL_CSR_VERSION_REQUIRED	CSR_VERSION(1, 6)
> >  
> > -#define I915_CSR_KBL "i915/kbl_dmc_ver1_01.bin"
> > +#define I915_CSR_KBL "i915/kbl_dmc_ver1_04.bin"
> >  MODULE_FIRMWARE(I915_CSR_KBL);
> > -#define KBL_CSR_VERSION_REQUIRED	CSR_VERSION(1, 1)
> > +#define KBL_CSR_VERSION_REQUIRED	CSR_VERSION(1, 4)
> >  
> >  #define I915_CSR_SKL "i915/skl_dmc_ver1_26.bin"
> >  MODULE_FIRMWARE(I915_CSR_SKL);
> 
> -- 
> Jani Nikula, Intel Open Source Technology Center