[Intel-gfx] [PATCH] drm/i915: Silence smatch for cmdparser

[Chris Wilson]

Quoting Gabriel Krisman Bertazi (2017-11-07 16:14:58)
> Chris Wilson <chris at chris-wilson.co.uk> writes:
> 
> > drivers/gpu/drm/i915/i915_cmd_parser.c:808:23: error: not an lvalue
> > drivers/gpu/drm/i915/i915_cmd_parser.c:811:23: error: not an lvalue
> > drivers/gpu/drm/i915/i915_cmd_parser.c:814:23: error: not an lvalue
> > drivers/gpu/drm/i915/i915_cmd_parser.c:808:23: error: not an lvalue
> > drivers/gpu/drm/i915/i915_cmd_parser.c:811:23: error: not an lvalue
> > drivers/gpu/drm/i915/i915_cmd_parser.c:814:23: error: not an lvalue
> > drivers/gpu/drm/i915/i915_cmd_parser.c:808:23: error: not an lvalue
> > drivers/gpu/drm/i915/i915_cmd_parser.c:811:23: error: not an lvalue
> > drivers/gpu/drm/i915/i915_cmd_parser.c:814:23: error: not an lvalue
> > drivers/gpu/drm/i915/i915_cmd_parser.c:808:23: error: not an lvalue
> > drivers/gpu/drm/i915/i915_cmd_parser.c:811:23: error: not an lvalue
> > drivers/gpu/drm/i915/i915_cmd_parser.c:814:23: error: not an lvalue
> >
> > If we move the shift into each case not only do we kill the warning from
> > smatch, but we shrink the code slightly:
> >
> >    text          data     bss     dec     hex filename
> > 1267906         20587    3168 1291661  13b58d before
> > 1267890         20587    3168 1291645  13b57d after
> >
> > Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> > Cc: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>
> > Cc: Mika Kuoppala <mika.kuoppala at linux.intel.com>
> > Cc: Matthew Auld <matthew.william.auld at gmail.com>
> 
> Reviewed-by: Gabriel Krisman Bertazi <krisman at collabora.co.uk>

Thank you both for the review, and pushed.
-Chris