[Intel-gfx] [PATCH] HAX: WARN_ON(crtc->crc.opened during disable)

[Ville Syrjälä]

On Wed, Nov 08, 2017 at 12:11:30PM +0100, Maarten Lankhorst wrote:
> ---
>  drivers/gpu/drm/i915/intel_display.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index 39d1f30cd0c4..436374b08b69 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -12176,6 +12176,7 @@ static void intel_atomic_commit_tail(struct drm_atomic_state *state)
>  
>  		if (old_crtc_state->active) {
>  			intel_crtc_disable_planes(crtc, old_crtc_state->plane_mask);
> +			WARN_ON(crtc->crc.opened);

Why? I actually want to keep crc capture alive across a modeset to be
able to observe every crc coming out of the hardware. Without that there
is no good way to figure out which crcs are good and which are bad.

>  			dev_priv->display.crtc_disable(to_intel_crtc_state(old_crtc_state), state);
>  			intel_crtc->active = false;
>  			intel_fbc_disable(intel_crtc);
> -- 
> 2.15.0
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Ville Syrjälä
Intel OTC