[Intel-gfx] [PATCH (resend) 3/3] drm/i915: Re-enable fastboot by default

[Daniel Vetter]

On Wed, Nov 08, 2017 at 10:29:22AM +0100, Maarten Lankhorst wrote:
> This fix was originally reverted because it left a chromebook pixel
> black, and no immediate fix was available. This has been fixed in the
> meantime.
> 
> Rather than trying to remove the parameter, set it to default to true
> for now, so we can always back out if required.
> 
> Signed-off-by: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>
> Cc: Jani Nikula <jani.nikula at intel.com>
> Cc: Daniel Vetter <daniel.vetter at ffwll.ch>
> Testcase: kms_panel_fitting

Mkay, per our irc discussion (pls add Ville to the cc of this patch) we
need one more bit:

In the pipe state compare functions, when the old mode is inherited and
either has_infoframes or has_audio (because of the eld crap) is set, then
we need to force a full modeset. Since atm we don't patch that up
properly. Maybe wrap that logic up into a PIPE_CONF_INCOMPLETE_STATE_CHECK
macro or something like that:

#define PIPE_CONF_INCOMPLETE_STATE_CHECK(name)

if (current_config->flags & INHERITED) {
	if (current_config->name || pipe_config->name) {
		pipe_config_err(...)
		ret = false;
	}
}

Or something like that.

With that fixed I think/hope we're finally done with this thing.
-Daniel

> ---
>  drivers/gpu/drm/i915/i915_params.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_params.h b/drivers/gpu/drm/i915/i915_params.h
> index c7292268ed43..b99cb58801e6 100644
> --- a/drivers/gpu/drm/i915/i915_params.h
> +++ b/drivers/gpu/drm/i915/i915_params.h
> @@ -57,7 +57,7 @@
>  	param(bool, alpha_support, IS_ENABLED(CONFIG_DRM_I915_ALPHA_SUPPORT)) \
>  	param(bool, enable_cmd_parser, true) \
>  	param(bool, enable_hangcheck, true) \
> -	param(bool, fastboot, false) \
> +	param(bool, fastboot, true) \
>  	param(bool, prefault_disable, false) \
>  	param(bool, load_detect_test, false) \
>  	param(bool, force_reset_modeset_test, false) \
> -- 
> 2.15.0
> 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch