[Intel-gfx] [PATCH 0/7] Add Plane Color Properties

[Shankar, Uma]

>-----Original Message-----
>From: Daniel Stone [mailto:daniel at fooishbar.org]
>Sent: Tuesday, November 7, 2017 9:44 PM
>To: Shankar, Uma <uma.shankar at intel.com>
>Cc: intel-gfx <intel-gfx at lists.freedesktop.org>; dri-devel <dri-
>devel at lists.freedesktop.org>; Syrjala, Ville <ville.syrjala at intel.com>; Lankhorst,
>Maarten <maarten.lankhorst at intel.com>
>Subject: Re: [Intel-gfx] [PATCH 0/7] Add Plane Color Properties
>
>Hi Uma,
>
>On 7 November 2017 at 12:06, Uma Shankar <uma.shankar at intel.com> wrote:
>> This patch series adds properties for plane color features. It adds
>> properties for degamma used to linearize data, CSC used for gamut
>> conversion, and gamma used to again non-linearize data as per panel
>> supported color space. These can be utilize by user space to convert
>> planes from one format to another, one color space to another etc.
>>
>> Usersapce can take smart blending decisions and utilize these hardware
>> supported plane color features to get accurate color profile. The same
>> can help in consistent color quality from source to panel taking
>> advantage of advanced color features in hardware.
>>
>> These patches just add the property interfaces and enable helper functions.
>
>This is missing documentation on how plane colour management interacts with
>CRTC colour management. Is it a step before CRTC colour management is
>applied, or does it bypass CRTC colour management, or ... ?
>

We can have color correction at 2 places in the Display hardware pipeline
1. At plane level (before blending)
2. At pipe level (after blending)

Both can be used and function independently of each other. Typical use case can be:

2 Layers planes/overlays with different color space and formats. These can be converted to one
common color space using the plane level color correction, then blended together. If needed 
pipe color correction can be applied on the blended output (based on use case and scenarios)

Regards,
Uma Shankar


>Cheers,
>Daniel