[Intel-gfx] [PATCH 0/5] drm: drm_plane_helper_check_state() related stuff

[Ville Syrjälä]

On Fri, Nov 10, 2017 at 01:26:47PM -0800, Sinclair Yeh wrote:
> Sorry this took so long.

No worries.

> 
> The vmwgfx part:  Reviewed-by: Sinclair Yeh <syeh at vmware.com>
> 
> I've done some testing and the vmwgfx part looks good.  Has Daniel
> already taken these or should I put them in my next request?

You can take them, or I can push them to drm-misc-next. Whatever
works best for you.

And I'll want to revisit this topic soonish and move the clip
handling into the helper as discussed with Daniel. But that can
wait a bit until we get this round merged somewhere.

> 
> Sinclair
> 
> On Wed, Nov 01, 2017 at 08:29:15PM +0200, Ville Syrjala wrote:
> > From: Ville Syrjälä <ville.syrjala at linux.intel.com>
> > 
> > While trawling the tree I spotted some issues with the way vmwgfx
> > uses drm_plane_helper_check_state(). Here's my attempt at fixing it.
> > Do note that I haven't actually tested the resulting code at all,
> > but it does build at least.
> > 
> > And while touching that general area I took up Daniel's suggestion from
> > long ago that drm_plane_helper_check_state() should be renamed and
> > relocated to better reflect its status.
> > 
> > Here's a branch with the entire series:
> > git://github.com/vsyrjala/linux.git atomic_helper_plane_stuff
> > 
> > Cc: VMware Graphics <linux-graphics-maintainer at vmware.com>
> > Cc: Sinclair Yeh <syeh at vmware.com>
> > Cc: Thomas Hellstrom <thellstrom at vmware.com>
> > Cc: Daniel Vetter <daniel at ffwll.ch>
> > 
> > Ville Syrjälä (5):
> >   drm/vmwgfx: Remove bogus crtc coords vs fb size check
> >   drm/vmwgfx: Use drm_plane_helper_check_state()
> >   drm/vmwgfx: Try to fix plane clipping
> >   drm: Check crtc_state->enable rather than crtc->enabled in
> >     drm_plane_helper_check_state()
> >   drm: Move drm_plane_helper_check_state() into drm_atomic_helper.c
> > 
> >  drivers/gpu/drm/arm/hdlcd_crtc.c            |   8 +-
> >  drivers/gpu/drm/arm/malidp_planes.c         |   3 +-
> >  drivers/gpu/drm/drm_atomic_helper.c         |  95 ++++++++++++++++++++++++
> >  drivers/gpu/drm/drm_plane_helper.c          | 111 +++-------------------------
> >  drivers/gpu/drm/drm_simple_kms_helper.c     |   9 ++-
> >  drivers/gpu/drm/i915/intel_display.c        |  20 ++---
> >  drivers/gpu/drm/imx/ipuv3-plane.c           |   8 +-
> >  drivers/gpu/drm/mediatek/mtk_drm_plane.c    |   8 +-
> >  drivers/gpu/drm/meson/meson_plane.c         |   8 +-
> >  drivers/gpu/drm/msm/mdp/mdp5/mdp5_plane.c   |   5 +-
> >  drivers/gpu/drm/nouveau/nv50_display.c      |  18 +++--
> >  drivers/gpu/drm/rockchip/rockchip_drm_vop.c |   6 +-
> >  drivers/gpu/drm/tegra/dc.c                  |   4 +-
> >  drivers/gpu/drm/vmwgfx/vmwgfx_kms.c         |  40 ++++------
> >  drivers/gpu/drm/zte/zx_plane.c              |  15 ++--
> >  include/drm/drm_atomic_helper.h             |   7 ++
> >  include/drm/drm_plane_helper.h              |   5 --
> >  17 files changed, 187 insertions(+), 183 deletions(-)
> > 
> > -- 
> > 2.13.6
> > 

-- 
Ville Syrjälä
Intel OTC