[Intel-gfx] [RFC 0/3] GuC functions name/prototype update

Oscar Mateo oscar.mateo at intel.com
Sat Nov 11 00:26:56 UTC 2017



On 11/10/2017 01:59 AM, Sagar Arun Kamble wrote:
> We want to have consistent function/structure/file naming and
> function parameter semantics. Suggestion from Michal Wajdeczko about
> using "genx_" prefix (or better _genx" suffix for all hw related
> structures types, offsets), "i915_" prefix for driver entry calls and
> "intel_" in all other seems to be the good scheme to go ahead.
> Also we need to adhere to practise of passing drm_i915_private to
> functions with "i915_" prefix and component structure to functions
> with "intel_" prefix. This series updates GuC submission related code
> with these changes.
>
> With GuC submission being hardware interface for i915, we should name
> those functions with prefix "intel_guc" and pass struct intel_guc as
> parameter. Also i915_guc_client struct is kernel-hw interaction
> structure hence rename that to intel_guc_client.
> With these changes GuC submission source files are now named with
> "intel_" prefix.
>

Acked-by: Oscar Mateo <oscar.mateo at intel.com>


More information about the Intel-gfx mailing list