[Intel-gfx] [PATCH 1/4] drm/i915/guc: Update name and prototype of GuC submission related functions
Chris Wilson
chris at chris-wilson.co.uk
Tue Nov 14 12:31:44 UTC 2017
Quoting Michal Wajdeczko (2017-11-14 12:23:18)
> On Mon, 13 Nov 2017 09:48:11 +0100, Sagar Arun Kamble
> > -static void i915_guc_submission_unpark(struct intel_engine_cs *engine)
> > +static void intel_guc_submission_unpark(struct intel_engine_cs *engine)
>
> Both park/unpark are also static and do not require "intel" prefix.
Hooks are an interesting one, because they are exported via the vfuncs
even though they are static. Here, the export is onto to other i915
functions so it is reasonably clear, but if we export a vfunc further
afield having the intel_ prefix is useful to mark the boundary into our
module.
-Chris
More information about the Intel-gfx
mailing list