[Intel-gfx] [PATCH v3 1/6] drm/i915: Update execlists tasklet naming

Michal Wajdeczko michal.wajdeczko at intel.com
Thu Nov 16 14:08:06 UTC 2017


On Thu, 16 Nov 2017 14:32:37 +0100, Sagar Arun Kamble  
<sagar.a.kamble at intel.com> wrote:

> intel_lrc_irq_handler and i915_guc_irq_handler are HW submission related
> tasklet functions. Name them with "submission_tasklet" suffix and
> remove intel/i915 prefix as they are static. Also rename irq_tasklet
> as just tasklet for clarity.
>
> v2: s/_bh/_tasklet (Chris)
>
> Suggested-by: Michal Wajdeczko <michal.wajdeczko at intel.com>
> Signed-off-by: Sagar Arun Kamble <sagar.a.kamble at intel.com>
> Cc: Michal Wajdeczko <michal.wajdeczko at intel.com>
> Cc: Michal Winiarski <michal.winiarski at intel.com>
> Cc: Chris Wilson <chris at chris-wilson.co.uk>
> Cc: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>
> ---

<snip>

> diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.h  
> b/drivers/gpu/drm/i915/intel_ringbuffer.h
> index 0531d93..f867aa6 100644
> --- a/drivers/gpu/drm/i915/intel_ringbuffer.h
> +++ b/drivers/gpu/drm/i915/intel_ringbuffer.h
> @@ -194,9 +194,9 @@ struct i915_priolist {
>   */
>  struct intel_engine_execlists {
>  	/**
> -	 * @irq_tasklet: softirq tasklet for bottom handler
> +	 * @tasklet: softirq tasklet for bottom handler

I hope that some day we provide some valuable description here
but I guess this can wait little more, so

Reviewed-by: Michal Wajdeczko <michal.wajdeczko at intel.com>

>  	 */
> -	struct tasklet_struct irq_tasklet;
> +	struct tasklet_struct tasklet;
> 	/**
>  	 * @default_priolist: priority list for I915_PRIORITY_NORMAL


More information about the Intel-gfx mailing list