[Intel-gfx] [PATCH v2 02/10] drm/uapi: Validate the mode flags/type

Ville Syrjälä ville.syrjala at linux.intel.com
Wed Nov 15 18:11:59 UTC 2017


On Wed, Nov 15, 2017 at 06:02:59PM +0000, Jose Abreu wrote:
> Hi Ville,
> 
> On 15-11-2017 15:49, Ville Syrjala wrote:
> >  
> > +#define  DRM_MODE_FLAG_ALL	(DRM_MODE_FLAG_PHSYNC |		\
> > +				 DRM_MODE_FLAG_NHSYNC |		\
> > +				 DRM_MODE_FLAG_PVSYNC |		\
> > +				 DRM_MODE_FLAG_NVSYNC |		\
> > +				 DRM_MODE_FLAG_INTERLACE |	\
> > +				 DRM_MODE_FLAG_DBLSCAN |	\
> > +				 DRM_MODE_FLAG_CSYNC |		\
> > +				 DRM_MODE_FLAG_PCSYNC |		\
> > +				 DRM_MODE_FLAG_NCSYNC |		\
> > +				 DRM_MODE_FLAG_HSKEW |		\
> > +				 DRM_MODE_FLAG_BCAST |		\
> > +				 DRM_MODE_FLAG_PIXMUX |		\
> > +				 DRM_MODE_FLAG_DBLCLK |		\
> > +				 DRM_MODE_FLAG_CLKDIV2 |	\
> > +				 DRM_MODE_FLAG_3D_MASK)
> > +
> >  
> 
> I see this doesn't include the picture aspect ratio flags.
> Shouldn't we add this now so that userspace can start using them?

Not until we have the client cap to keep them hidden from userspace that
isn't prepared to see them.

-- 
Ville Syrjälä
Intel OTC


More information about the Intel-gfx mailing list