[Intel-gfx] [PATCH 3/4] drm/i915/execlists: Assert that we don't get mixed IDLE_ACTIVE | COMPLETE events

Chris Wilson chris at chris-wilson.co.uk
Mon Nov 20 15:51:33 UTC 2017


Quoting Joonas Lahtinen (2017-11-20 13:25:58)
> On Mon, 2017-11-20 at 12:34 +0000, Chris Wilson wrote:
> > If IDLE_ACTIVE is set, then all other bits are invalid. For us, we can
> > assert that if we see a COMPLETE | PREEMPTED event, then it should be
> > impossible for it to also contain an IDLE_ACTIVE flag.
> > 
> > Suggested-by: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>
> > Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> > Cc: Mika Kuoppala <mika.kuoppala at linux.intel.com>
> > Cc: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
> > Cc: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>
> > Cc: Michal Winiarski <michal.winiarski at intel.com>
> > Cc: Michel Thierry <michel.thierry at intel.com>
> 
> Reviewed-by: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>

Applied up to this point, as we are just tidying and adding more
asserts. The next patch is the crutch.
-Chris


More information about the Intel-gfx mailing list