[Intel-gfx] [PATCH igt] benchmarks/gem_exec_nop: fix engines selection

Chris Wilson chris at chris-wilson.co.uk
Mon Nov 20 20:41:44 UTC 2017


Quoting Dmitry Rogozhkin (2017-11-20 11:49:46)
> Code on loop() function shadowed function parameter which led
> to inability to try out different engines in the test: we always
> loaded RCS0.
> 
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103804
> Signed-off-by: Dmitry Rogozhkin <dmitry.v.rogozhkin at intel.com>
> Cc: Chris Wilson <chris at chris-wilson.co.uk>
Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>

> ---
>  benchmarks/gem_exec_nop.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/benchmarks/gem_exec_nop.c b/benchmarks/gem_exec_nop.c
> index 03a0354..8eb88c1 100644
> --- a/benchmarks/gem_exec_nop.c
> +++ b/benchmarks/gem_exec_nop.c
> @@ -106,11 +106,11 @@ static int loop(unsigned ring, int reps, int ncpus, unsigned flags)
>                 return 77;
>  
>         all_nengine = 0;
> -       for (ring = 1; ring < 16; ring++) {
> +       for (unsigned r = 1; r < 16; r++) {
>                 execbuf.flags &= ~ENGINE_FLAGS;
> -               execbuf.flags |= ring;
> +               execbuf.flags |= r;
>                 if (__gem_execbuf(fd, &execbuf) == 0)
> -                       all_engines[all_nengine++] = ring;
> +                       all_engines[all_nengine++] = r;
>         }

Exactly what I did on Sat and forgot to send on.
-Chris


More information about the Intel-gfx mailing list