[Intel-gfx] [PATCH i-g-t] overlay: Fix compiler warning when compiling with meson

Chris Wilson chris at chris-wilson.co.uk
Tue Nov 21 13:32:47 UTC 2017


Quoting Maarten Lankhorst (2017-11-21 13:26:50)

meson isn't required, just a recent gcc.

> [1/316] Compiling C object 'overlay/intel-gpu-overlay at exe/overlay.c.o'.
> ../overlay/overlay.c: In function ‘show_gem_objects’:
> ../overlay/overlay.c:798:31: warning: ‘%s’ directive output may be truncated writing up to 255 bytes into a region of size 160 [-Wformat-truncation=]
>    snprintf(buf, sizeof(buf), "%s %ldMB, %ld objects",
>                                ^~
> ../overlay/overlay.c:798:30: note: using the range [-9223372036854775808, 9223372036854775807] for directive argument
>    snprintf(buf, sizeof(buf), "%s %ldMB, %ld objects",
>                               ^~~~~~~~~~~~~~~~~~~~~~~
> ../overlay/overlay.c:798:30: note: using the range [-9223372036854775808, 9223372036854775807] for directive argument
> ../overlay/overlay.c:798:3: note: ‘snprintf’ output between 16 and 309 bytes into a destination of size 160
>    snprintf(buf, sizeof(buf), "%s %ldMB, %ld objects",
>    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>     comm->name, comm->bytes >> 20, comm->count);
> 
> Might as well give it the 309 bytes it wants, plus on more. :-)
> 
> Signed-off-by: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>
Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
-Chris


More information about the Intel-gfx mailing list