[Intel-gfx] [PATCH] drm/i915: Remove success dmesg noise for intel_rotate_pages()

[Chris Wilson]

Quoting Tvrtko Ursulin (2017-11-22 17:02:14)
> 
> On 22/11/2017 14:56, Chris Wilson wrote:
> > During selftesting intel_rotate_pages() is very, very verbose without
> > giving us any information. Suppress the noise.
> > 
> > Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> > Cc: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
> > ---
> >   drivers/gpu/drm/i915/i915_gem_gtt.c | 7 ++-----
> >   1 file changed, 2 insertions(+), 5 deletions(-)
> > 
> > diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i915_gem_gtt.c
> > index e101b9a98957..41a203e0c160 100644
> > --- a/drivers/gpu/drm/i915/i915_gem_gtt.c
> > +++ b/drivers/gpu/drm/i915/i915_gem_gtt.c
> > @@ -3737,9 +3737,6 @@ intel_rotate_pages(struct intel_rotation_info *rot_info,
> >                                 rot_info->plane[i].stride, st, sg);
> >       }
> >   
> > -     DRM_DEBUG_KMS("Created rotated page mapping for object size %zu (%ux%u tiles, %u pages)\n",
> > -                   obj->base.size, rot_info->plane[0].width, rot_info->plane[0].height, size);
> > -
> 
> Fair.
> 
> >       kvfree(page_addr_list);
> >   
> >       return st;
> > @@ -3749,8 +3746,8 @@ intel_rotate_pages(struct intel_rotation_info *rot_info,
> >   err_st_alloc:
> >       kvfree(page_addr_list);
> >   
> > -     DRM_DEBUG_KMS("Failed to create rotated mapping for object size %zu! (%ux%u tiles, %u pages)\n",
> > -                   obj->base.size, rot_info->plane[0].width, rot_info->plane[0].height, size);
> > +     DRM_DEBUG_DRIVER("Failed to create rotated mapping for object size %zu! (%ux%u tiles, %u pages)\n",
> > +                      obj->base.size, rot_info->plane[0].width, rot_info->plane[0].height, size);
> 
> Keep the failure perhaps?

I did? We're not KMS here, we are the driver allocating a view.
KMS/ATOMIC will get their turn to complain when they couldn't pin the
vma. I have to admit I was tempted to remove it, but thought that was a
step too far.
-Chris