[Intel-gfx] [PATCH] drm/i915/pmu: Turn on perf events in debug mode

[Tvrtko Ursulin]

On 22/11/2017 17:03, Chris Wilson wrote:
> Quoting Tvrtko Ursulin (2017-11-22 16:59:01)
>> From: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
>>
>> We have a policy to select all optional kernel features which are needed
>> for CI if DRM_I915_DEBUG is turned on. So add PERF_EVENTS as well.
>>
>> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
>> Suggested-by: Chris Wilson <chris at chris-wilson.co.uk>
>> ---
>>   drivers/gpu/drm/i915/Kconfig.debug | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/gpu/drm/i915/Kconfig.debug b/drivers/gpu/drm/i915/Kconfig.debug
>> index 9e53edbc713b..1a75cc94e759 100644
>> --- a/drivers/gpu/drm/i915/Kconfig.debug
>> +++ b/drivers/gpu/drm/i915/Kconfig.debug
>> @@ -29,6 +29,7 @@ config DRM_I915_DEBUG
>>          select DRM_I915_SW_FENCE_DEBUG_OBJECTS
>>          select DRM_I915_SELFTEST
>>          select DRM_I915_TRACE_GEM
>> +       select PERF_EVENTS
> 
> If I am reading arch/x86/Kconfig correctly, then PERF_EVENTS is always
> selected for X86.
> 
> config X86
> 	def_bool y
> 	...
> 	select HAVE_PERF_EVENTS
> 	...
> 	select PERF_EVENTS
> 	...
> 
> Is it worth documenting our need for the syscall to run igt/perf_pmu
> anyway?

Probably not. I did not think to check this, and actually, don't think I 
would have expected it. So thanks for checking!

Regards,

Tvrtko