[Intel-gfx] [PATCH i-g-t 5/5] tools/intel_watermark: Right justify register names

Pandiyan, Dhinakaran dhinakaran.pandiyan at intel.com
Wed Nov 22 23:44:32 UTC 2017


Reviewed-by: Dhinakaran Pandiyan <dhinakaran.pandiyan at intel.com> for the
series.


On Tue, 2017-11-21 at 20:49 +0200, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala at linux.intel.com>
> 
> I think the dump is a more legible when the register names
> are right justified. That way the register name and its value
> are right next to each other.
> 
> Cc: Dhinakaran Pandiyan <dhinakaran.pandiyan at intel.com>
> Cc: Tvrtko Ursulin <tvrtko.ursulin at linux.intel.com>
> Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>
> ---
>  tools/intel_watermark.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/tools/intel_watermark.c b/tools/intel_watermark.c
> index 3c70f4ec54fb..308e351dcd2f 100644
> --- a/tools/intel_watermark.c
> +++ b/tools/intel_watermark.c
> @@ -248,7 +248,7 @@ static void skl_wm_dump(void)
>  	}
>  
>  	for (pipe = 0; pipe < num_pipes; pipe++) {
> -		printf("%-18s 0x%08x\t",
> +		printf("%18s 0x%08x\t",
>  		       skl_wm_linetime_reg_name(pipe),
>  		       wm_linetime[pipe]);
>  	}
> @@ -260,7 +260,7 @@ static void skl_wm_dump(void)
>  				if (plane >= skl_num_planes(devid, pipe))
>  					break;
>  
> -				printf("%-18s 0x%08x\t" ,
> +				printf("%18s 0x%08x\t" ,
>  				       skl_wm_reg_name(pipe, plane, level),
>  				       wm[level][pipe][plane]);
>  			}
> @@ -274,7 +274,7 @@ static void skl_wm_dump(void)
>  			if (plane >= skl_num_planes(devid, pipe))
>  				break;
>  
> -			printf("%-18s 0x%08x\t",
> +			printf("%18s 0x%08x\t",
>  			       skl_wm_trans_reg_name(pipe, plane),
>  			       wm_trans[pipe][plane]);
>  		}
> @@ -287,7 +287,7 @@ static void skl_wm_dump(void)
>  			if (plane >= skl_num_planes(devid, pipe))
>  				break;
>  
> -			printf("%-18s 0x%08x\t",
> +			printf("%18s 0x%08x\t",
>  			       skl_buf_cfg_reg_name(pipe, plane),
>  			       buf_cfg[pipe][plane]);
>  		}


More information about the Intel-gfx mailing list