[Intel-gfx] [PATCH] drm/i915/pmu: Aggregate all RC6 states into one counter

Chris Wilson chris at chris-wilson.co.uk
Fri Nov 24 18:28:59 UTC 2017


Quoting Chris Wilson (2017-11-24 18:19:03)
> Quoting Tvrtko Ursulin (2017-11-24 17:13:31)
> > From: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
> > 
> > Chris has discovered that RC6, RC6p and RC6pp counters are mutually
> > exclusive, and even that on some SNB SKUs you get RC6p increasing, and on
> > the others RC6.
> > 
> > Furthermore RC6p and RC6pp were only present starting from GEN6 until,
> > GEN7, not including Haswell.
> > 
> > All this combined makes it questionable whether we need to reserve new ABI
> > for these counters. One idea was to just combine them all under the RC6
> > counter to simplify things for userspace. So that is what this patch does.
> > 
> > Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
> > Suggested-by: Chris Wilson <chris at chris-wilson.co.uk>
> 
> (Wrong mail!)
> 
> First run failed: (perf_pmu:1928) CRITICAL: 'idle - prev' != 'slept'
> (1884715520.000000 not within 5.000000% tolerance of 2000133450.000000)

Subsequent runs, ok. Shrug.
-Chris


More information about the Intel-gfx mailing list