[Intel-gfx] [PATCH 8/9] drm/i915: make mappable struct resource centric
Chris Wilson
chris at chris-wilson.co.uk
Fri Nov 24 22:22:19 UTC 2017
Quoting Matthew Auld (2017-11-24 21:29:29)
> Signed-off-by: Matthew Auld <matthew.auld at intel.com>
> Cc: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>
> Cc: Chris Wilson <chris at chris-wilson.co.uk>
> Cc: Paulo Zanoni <paulo.r.zanoni at intel.com>
> ---
> diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.h b/drivers/gpu/drm/i915/i915_gem_gtt.h
> index 6eb34fd2c4ba..a91281a55b91 100644
> --- a/drivers/gpu/drm/i915/i915_gem_gtt.h
> +++ b/drivers/gpu/drm/i915/i915_gem_gtt.h
> @@ -368,9 +368,9 @@ i915_vm_has_scratch_64K(struct i915_address_space *vm)
> */
> struct i915_ggtt {
> struct i915_address_space base;
> - struct io_mapping mappable; /* Mapping to our CPU mappable region */
>
> - phys_addr_t mappable_base; /* PA of our GMADR */
> + struct io_mapping mappable_io; /* Mapping to our CPU mappable region */
> + struct resource mappable; /* GMADR resource */
How about
struct io_mapping iomap;
struct resource gmadr;
?
ggtt->iomap I think is going to be less confusing than ggtt->mappable
going forwards.
-Chris
More information about the Intel-gfx
mailing list