[Intel-gfx] [PATCH 1/2] drm/i915: Move engine->needs_cmd_parser to engine->flags

Joonas Lahtinen joonas.lahtinen at linux.intel.com
Mon Nov 27 10:18:34 UTC 2017


On Fri, 2017-11-24 at 11:21 +0000, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
> 
> Will be adding a new per-engine flags shortly so it makes sense
> to consolidate.
> 
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
> Suggested-by: Chris Wilson <chris at chris-wilson.co.uk>

<SNIP>

> @@ -952,10 +953,8 @@ void intel_engine_init_cmd_parser(struct intel_engine_cs *engine)
>   */
>  void intel_engine_cleanup_cmd_parser(struct intel_engine_cs *engine)
>  {
> -	if (!engine->needs_cmd_parser)
> -		return;
> -
> -	fini_hash_table(engine);
> +	if (intel_engine_needs_cmd_parser(engine))
> +		fini_hash_table(engine);

Just keep the previous code flow.

Reviewed-by: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>

Regards, Joonas
-- 
Joonas Lahtinen
Open Source Technology Center
Intel Corporation


More information about the Intel-gfx mailing list