[Intel-gfx] [PATCH 1/2] drm/i915: follow single notation for workaround number

[Rodrigo Vivi]

On Tue, Nov 28, 2017 at 09:08:19PM +0000, Lucas De Marchi wrote:
> Cc: Ville Syrjälä <ville.syrjala at linux.intel.com>
> Signed-off-by: Lucas De Marchi <lucas.demarchi at intel.com>
> ---
>  drivers/gpu/drm/i915/intel_display.c | 2 +-
>  drivers/gpu/drm/i915/intel_hdmi.c    | 2 +-
>  drivers/gpu/drm/i915/intel_pm.c      | 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index 76c75d34e799..9a0ebf205435 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -15126,7 +15126,7 @@ get_encoder_power_domains(struct drm_i915_private *dev_priv)
>  
>  static void intel_early_display_was(struct drm_i915_private *dev_priv)
>  {
> -	/* Display WA #1185 WaDisableDARBFClkGating:cnl,glk */
> +	/* Display WA #1185 WaDisableDARBFClkGating: cnl,glk */

If you introduce the space here I believe this patch will need to get bigger.
probably to just leave without it.

>  	if (IS_CANNONLAKE(dev_priv) || IS_GEMINILAKE(dev_priv))
>  		I915_WRITE(GEN9_CLKGATE_DIS_0, I915_READ(GEN9_CLKGATE_DIS_0) |
>  			   DARBF_GATING_DIS);
> diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/drivers/gpu/drm/i915/intel_hdmi.c
> index 9d5e72728475..691600ce48c4 100644
> --- a/drivers/gpu/drm/i915/intel_hdmi.c
> +++ b/drivers/gpu/drm/i915/intel_hdmi.c
> @@ -1380,7 +1380,7 @@ static bool hdmi_12bpc_possible(const struct intel_crtc_state *crtc_state)
>  		}
>  	}
>  
> -	/* Display Wa #1139 */
> +	/* Display WA #1139 */

maybe good to add the affected platforms here as well?

>  	if (IS_GLK_REVID(dev_priv, 0, GLK_REVID_A1) &&
>  	    crtc_state->base.adjusted_mode.htotal > 5460)
>  		return false;
> diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> index a80c322c5b43..7905b8313e40 100644
> --- a/drivers/gpu/drm/i915/intel_pm.c
> +++ b/drivers/gpu/drm/i915/intel_pm.c
> @@ -61,7 +61,7 @@ static void gen9_init_clock_gating(struct drm_i915_private *dev_priv)
>  	if (HAS_LLC(dev_priv)) {
>  		/*
>  		 * WaCompressedResourceDisplayNewHashMode:skl,kbl
> -		 * Display WA#0390: skl,kbl
> +		 * Display WA #0390: skl,kbl
>  		 *
>  		 * Must match Sampler, Pixel Back End, and Media. See
>  		 * WaCompressedResourceSamplerPbeMediaNewHashMode.
> -- 
> 2.14.3
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx