[Intel-gfx] [PATCH] drm/i915: Tidy up signed/unsigned comparison

Michal Wajdeczko michal.wajdeczko at intel.com
Thu Nov 30 15:08:27 UTC 2017


On Thu, 30 Nov 2017 13:52:53 +0100, Chris Wilson  
<chris at chris-wilson.co.uk> wrote:

> drivers/gpu/drm/i915/i915_irq.c|3096 col 29| error: comparison between  
> signed and unsigned integer expressions [-Werror=sign-compare]
>
> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> Cc: Ville Syrjälä <ville.syrjala at linux.intel.com>
> ---

Reviewed-by: Michal Wajdeczko <michal.wajdeczko at intel.com>

>  drivers/gpu/drm/i915/i915_irq.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_irq.c  
> b/drivers/gpu/drm/i915/i915_irq.c
> index 4fb183ae7a07..7cac07db89b9 100644
> --- a/drivers/gpu/drm/i915/i915_irq.c
> +++ b/drivers/gpu/drm/i915/i915_irq.c
> @@ -3068,7 +3068,7 @@ static void vlv_display_irq_reset(struct  
> drm_i915_private *dev_priv)
>  	i9xx_pipestat_irq_reset(dev_priv);
> 	GEN3_IRQ_RESET(VLV_);
> -	dev_priv->irq_mask = ~0;
> +	dev_priv->irq_mask = ~0u;
>  }
> static void vlv_display_irq_postinstall(struct drm_i915_private  
> *dev_priv)
> @@ -3093,7 +3093,7 @@ static void vlv_display_irq_postinstall(struct  
> drm_i915_private *dev_priv)
>  		enable_mask |= I915_DISPLAY_PIPE_C_EVENT_INTERRUPT |
>  			I915_LPE_PIPE_C_INTERRUPT;
> -	WARN_ON(dev_priv->irq_mask != ~0);
> +	WARN_ON(dev_priv->irq_mask != ~0u);
> 	dev_priv->irq_mask = ~enable_mask;


More information about the Intel-gfx mailing list