[Intel-gfx] [PATCH 2/2] dim: sign pull-request tags if the GPG key is configured

Jani Nikula jani.nikula at intel.com
Mon Oct 2 14:05:12 UTC 2017


On Mon, 02 Oct 2017, Jani Nikula <jani.nikula at intel.com> wrote:
> On Mon, 11 Sep 2017, Sean Paul <seanpaul at chromium.org> wrote:
>> On Mon, Sep 11, 2017 at 9:16 AM, Jani Nikula <jani.nikula at intel.com> wrote:
>>> Add new environment variable $DIM_GPG_KEYID for configuring the GPG key
>>> ID of the key to use for signing tags for pull requests. The tags will
>>> be signed if the key ID is set, otherwise annotated tags will be used
>>> like before.
>>>
>>> The drm-intel-testing tags are left unsigned, at least for now.
>>>
>>> Cc: Daniel Vetter <daniel.vetter at ffwll.ch>
>>> Cc: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>
>>> Cc: Rodrigo Vivi <rodrigo.vivi at intel.com>
>>> Cc: Sean Paul <seanpaul at chromium.org>
>>> Signed-off-by: Jani Nikula <jani.nikula at intel.com>
>>>
>>> ---
>>>
>>> BEWARE OF THE LEOPARD! I didn't actually test this. I will try it when I
>>> need to tag something next.
>>>
>>
>> Just comment out git push and test this?
>
> Finally got around to trying this out, works fine:
> https://cgit.freedesktop.org/drm-intel/tag/?id=drm-intel-next-2017-09-29
>
> The only snag is that now prep_pull_mail_overview() picks up the
> signature from the tag object to the overview too.
>
> Ack on merging these two out of the way, and fixing that separately (a
> tiny bit of sed)?

I pushed these two and the sed bit to strip signatures with Daniel's
acks.

You can now add

DIM_GPG_KEYID=<your-key-id>

to ~/.dimrc to have dim sign the tags.

BR,
Jani.


-- 
Jani Nikula, Intel Open Source Technology Center


More information about the Intel-gfx mailing list