[Intel-gfx] [PATCH 17/21] drm/i915/selftests: huge page tests

Chris Wilson chris at chris-wilson.co.uk
Tue Oct 3 09:49:44 UTC 2017


Quoting Matthew Auld (2017-09-29 17:10:28)
> +static unsigned int get_largest_page_size(struct drm_i915_private *i915,
> +                                         size_t rem)

Grr, I dislike size_t in the kernel. It's not tied to the physical
address size, or virtual address size (or either dma or ourselves).
In most cases you really do mean unsigned long, but often there's an
explicit type you could use. Note that they need u64 math protection (or
at least using the macros for handling longs).
-Chris


More information about the Intel-gfx mailing list