[Intel-gfx] [PATCH i-g-t 2/2] tests: Drop gem_bad_length as redundant

Chris Wilson chris at chris-wilson.co.uk
Tue Oct 3 13:49:28 UTC 2017


Quoting Joonas Lahtinen (2017-10-03 12:47:34)
> From: Daniele Ceraolo Spurio <daniele.ceraolospurio at intel.com>
> 
> Most of the gem_bad_length code is compiled out because creating
> a zero-length object is not allowed anymore by i915 and thus it is
> not possible to execute it. The remaining part checks that creation of
> a zero-length object does indeed fail, which is also checked by
> gem_create/create-invalid-size.
> The only difference between the 2 tests is that gem_bad_length checks
> specifically for EINVAL while create-invalid-size only looks for
> failure, so after adding the EINVAL check to create-invalid-size it is
> safe to drop gem_bad_length.
> 
> v2 (Joonas):
> - Clarify header line, split the patch, fix Meson build and add Cc:
> 
> Signed-off-by: Daniele Ceraolo Spurio <daniele.ceraolospurio at intel.com>
> Signed-off-by: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>
> Cc: Chris Wilson <chris at chris-wilson.co.uk>
Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
-Chris


More information about the Intel-gfx mailing list