[Intel-gfx] [PATCH v3 7/9] drm/i915/guc: Move GuC log declarations into dedicated header

[Chris Wilson]

Quoting Michal Wajdeczko (2017-10-03 19:28:02)
> On Tue, 03 Oct 2017 19:03:58 +0200, Chris Wilson  
> <chris at chris-wilson.co.uk> wrote:
> 
> > Quoting Michal Wajdeczko (2017-10-03 17:36:05)
> >> We want to keep component specific code in separate files.
> >>
> >> Suggested-by: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>
> >> Signed-off-by: Michal Wajdeczko <michal.wajdeczko at intel.com>
> >> Cc: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>
> >> Cc: Chris Wilson <chris at chris-wilson.co.uk>
> >> Cc: Sagar Arun Kamble <sagar.a.kamble at intel.com>
> >> ---
> >>  drivers/gpu/drm/i915/intel_guc_log.c |  1 +
> >>  drivers/gpu/drm/i915/intel_guc_log.h | 57  
> >> ++++++++++++++++++++++++++++++++++++
> >>  drivers/gpu/drm/i915/intel_uc.h      | 26 +---------------
> >>  3 files changed, 59 insertions(+), 25 deletions(-)
> >>  create mode 100644 drivers/gpu/drm/i915/intel_guc_log.h
> >>
> >> diff --git a/drivers/gpu/drm/i915/intel_guc_log.c  
> >> b/drivers/gpu/drm/i915/intel_guc_log.c
> >> index 6571d96..bd9b02e 100644
> >> --- a/drivers/gpu/drm/i915/intel_guc_log.c
> >> +++ b/drivers/gpu/drm/i915/intel_guc_log.c
> >> @@ -23,6 +23,7 @@
> >>   */
> >>  #include <linux/debugfs.h>
> >>  #include <linux/relay.h>
> >> +#include "intel_guc_log.h"
> >>  #include "i915_drv.h"
> >
> > Can we keep a newline between <> and "", and aim for alphabetical order.
> 
> I'll add newline in next spin, but I'm not sure about alphabetical order.
> 
> Note that Joonas wants all foo.c files to start with "foo.h" (after <>)
> and then followed by other headers to make dependencies more explicit.

I'm not fussed, though tbh I am more likely to forget which file I'm in
and so which special case to apply. 2 blocks of alphabetical includes is
simple enough for me to not muck up :)
-Chris