[Intel-gfx] [PATCH] drm/i915: Remove use_mmio_flip modparm, v2.

[Chris Wilson]

Quoting Maarten Lankhorst (2017-10-04 10:44:16)
> This has been unused since commit afa8ce5b3080
> ("drm/i915: Nuke legacy flip queueing code").
> 
> Changes since v1:
> - Rebase on top of all the changes to modparams.
> 
> Cc: Chris Wilson <chris at chris-wilson.co.uk>
> Signed-off-by: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>
> Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk> #v1
Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>

> \o/-by: Jani Nikula <jani.nikula at intel.com>
> ---
>  drivers/gpu/drm/i915/i915_params.c | 3 ---
>  drivers/gpu/drm/i915/i915_params.h | 1 -
>  drivers/gpu/drm/i915/intel_lrc.c   | 3 +--
>  3 files changed, 1 insertion(+), 6 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_params.c b/drivers/gpu/drm/i915/i915_params.c
> index 9dff323a83d3..b4faeb6aa2bd 100644
> --- a/drivers/gpu/drm/i915/i915_params.c
> +++ b/drivers/gpu/drm/i915/i915_params.c
> @@ -146,9 +146,6 @@ i915_param_named(disable_display, bool, 0400,
>  i915_param_named_unsafe(enable_cmd_parser, bool, 0400,
>         "Enable command parsing (true=enabled [default], false=disabled)");
>  
> -i915_param_named_unsafe(use_mmio_flip, int, 0600,
> -       "use MMIO flips (-1=never, 0=driver discretion [default], 1=always)");
> -
>  i915_param_named(mmio_debug, int, 0600,
>         "Enable the MMIO debug code for the first N failures (default: off). "
>         "This may negatively affect performance.");
> diff --git a/drivers/gpu/drm/i915/i915_params.h b/drivers/gpu/drm/i915/i915_params.h
> index 4f3f8d650194..c7292268ed43 100644
> --- a/drivers/gpu/drm/i915/i915_params.h
> +++ b/drivers/gpu/drm/i915/i915_params.h
> @@ -49,7 +49,6 @@
>         param(int, guc_log_level, -1) \
>         param(char *, guc_firmware_path, NULL) \
>         param(char *, huc_firmware_path, NULL) \
> -       param(int, use_mmio_flip, 0) \
>         param(int, mmio_debug, 0) \
>         param(int, edp_vswing, 0) \
>         param(int, reset, 2) \
> diff --git a/drivers/gpu/drm/i915/intel_lrc.c b/drivers/gpu/drm/i915/intel_lrc.c
> index 7d6da130b184..6ea5ecf08230 100644
> --- a/drivers/gpu/drm/i915/intel_lrc.c
> +++ b/drivers/gpu/drm/i915/intel_lrc.c
> @@ -244,8 +244,7 @@ int intel_sanitize_enable_execlists(struct drm_i915_private *dev_priv, int enabl
>                 return 0;
>  
>         if (HAS_LOGICAL_RING_CONTEXTS(dev_priv) &&
> -           USES_PPGTT(dev_priv) &&
> -           i915_modparams.use_mmio_flip >= 0)
> +           USES_PPGTT(dev_priv))
>                 return 1;
>  
>         return 0;
> -- 
> 2.14.1
>