[Intel-gfx] [PATCH v3 4/9] drm/i915/uc: Move uC fw helper code into dedicated files

[Michal Wajdeczko]

On Wed, 04 Oct 2017 16:23:50 +0200, Joonas Lahtinen  
<joonas.lahtinen at linux.intel.com> wrote:

> On Tue, 2017-10-03 at 16:36 +0000, Michal Wajdeczko wrote:
>> This is a prerequisite to unblock next steps.
>>
>> v2: correct include order (Joonas)
>>
>> Signed-off-by: Michal Wajdeczko <michal.wajdeczko at intel.com>
>> Cc: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>
>> Cc: Chris Wilson <chris at chris-wilson.co.uk>
>> Cc: Sagar Arun Kamble <sagar.a.kamble at intel.com>
>> Reviewed-by: Sagar Arun Kamble <sagar.a.kamble at intel.com>
>
> s/i915_fetch_uc_fw/intel_uc_fw_init/

Actually, "fetch_uc" function is not symmetrical to "fw_init" so
above rename will be misleading. I'm planning to add below init
function after we are done with all moves:

intel_uc_fw_init(struct intel_uc_fw *fw, enum intel_uc_fw_type type);

Given above, can I still keep your r-b?

Michal

>
> And this is;
>
> Reviewed-by: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>
>
> Can you then re-submit these first four patches for CI results and I'll
> merge them.
>
> Regards, Joonas