[Intel-gfx] [PATCH 10/10] drm/i915: Introduce separate status variable for RC6 and Ring frequency setup

Sagar Arun Kamble sagar.a.kamble at intel.com
Wed Oct 4 18:41:35 UTC 2017



On 10/4/2017 10:36 PM, Chris Wilson wrote:
> Quoting Sagar Arun Kamble (2017-10-04 15:07:25)
>> Defined new struct intel_rc6 to hold RC6 specific state and
>> intel_ring_pstate to hold ring specific state.
> What do you mean by ring? Probably not struct intel_ring.
>
> For us it would be closer to intel_engine_cs_pstate, which is a bit
> unwieldy but a better starting point.
> -Chris
Yes. This naming is little confusing.
This is L3/LLC and interface between IA and DDR.
how about intel_llc_pstate?
Saw a patch https://patchwork.freedesktop.org/patch/105768/ that 
actually indicates HAS_LLC is equivalent to the
macro I had prepared earlier NEEDS_RING_FREQ_UPDATE. So will use HAS_LLC 
in these new functions for ring setup.



More information about the Intel-gfx mailing list