[Intel-gfx] [PATCH 02/10] drm/i915/guc: Initialize GuC before restarting engines

[Michał Winiarski]

On Thu, Oct 05, 2017 at 09:36:31AM +0000, Chris Wilson wrote:
> Quoting Michał Winiarski (2017-10-05 10:13:41)
> > Now that we're handling request resubmission the same way as regular
> > submission (from the tasklet), we can move GuC initialization earlier,
> > before restarting the engines. This way, we're no longer being in the
> > state of flux during engine restart - we're already in user requested
> > submission mode.
> 
> Do you remember why it was the other way around?

IIRC we were resubmitting directly from "intel_uc_init_hw".
I guess doing that without calling ->init_hw() first was harmful :)

-Michał

> 
> > Cc: Chris Wilson <chris at chris-wilson.co.uk>
> > Cc: Michal Wajdeczko <michal.wajdeczko at intel.com>
> > Cc: Michel Thierry <michel.thierry at intel.com>
> > Cc: Mika Kuoppala <mika.kuoppala at intel.com>
> > Cc: Oscar Mateo <oscar.mateo at intel.com>
> > Signed-off-by: Michał Winiarski <michal.winiarski at intel.com>
> Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
> -Chris