[Intel-gfx] [PATCH 2/3] drm/i915: Retire after wait-for-idle on evict

Chris Wilson chris at chris-wilson.co.uk
Sun Oct 8 13:56:59 UTC 2017


Quoting Chris Wilson (2017-10-08 14:43:21)
> We have to manually retire the requests in order to unpin the contexts,
> and thereby make their space available in the GGTT. So call retire after
> we idle the GPU to account for the lazy pinning.

Bah, no we moved the retire to i915_gem_wait_for_idle.

commit 72022a705e1da854653e56b67bef57b72f1392eb
Author: Chris Wilson <chris at chris-wilson.co.uk>
Date:   Thu Mar 30 15:50:38 2017 +0100

    drm/i915: Move retire-requests into i915_gem_wait_for_idle()
    
    As we now distinguish everywhere that can call
    i915_gem_retire_requests() following a successful wait_for_idle, we can
    remove the duplication by moving that call into i915_gem_wait_for_idle()
    itself.

Back to the drawing board why we weren't apparently able to clear the
pinned contexts from the GGTT.
-Chris


More information about the Intel-gfx mailing list