[Intel-gfx] [PATCH 2/2] drm/i915: Remove early invocations of i915_engines_cleanup()

[Joonas Lahtinen]

On Sat, 2017-10-07 at 09:56 +0100, Chris Wilson wrote:
> Engines are now only allocated during init_mmio, so we can forgo
> iterating over the empty list and calling kfree(NULL) prior to
> intel_engines_init_mmio().
> 
> Fixes: 63ffbcdadcf2 ("drm/i915: Sanitize engine context sizes")

This use of the tag would be correct according to "Fixes:" part of:

https://www.kernel.org/doc/html/v4.13/process/submitting-patches.html#r
eviewer-s-statement-of-oversight

But it definitely says "bug" in there, so the other more stylistic
issues "Impact: None", indeed should not get a Fixes: tag.

> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> Cc: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>
> Cc: Tvrtko Ursulin <tvrtko.ursulin at intel.com>

Reviewed-by: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>

Regards, Joonas
-- 
Joonas Lahtinen
Open Source Technology Center
Intel Corporation