[Intel-gfx] [PATCH 3/4] drm/i915/selftests: Hold the rpm/forcewake wakeref for the reset tests

Chris Wilson chris at chris-wilson.co.uk
Mon Oct 9 10:28:37 UTC 2017


Quoting Mika Kuoppala (2017-10-09 11:14:44)
> Chris Wilson <chris at chris-wilson.co.uk> writes:
> 
> > Resetting the engine requires us to hold the forcewake wakeref to
> > prevent RC6 trying to happen in the middle of the reset sequence.
> > Normally, this is taken by i915_handle_error(), but as we are calling
> 
> There is no explicit forcewake grab on i915_handle_error().
> What I am missing in here?

No, you are right, I was thinking of the rpm wakeref. Ok, that means I
should push the problem into the reset sequence. First thought is
i915_gem_reset_prepare, but we want transparency between global/engine
resets. Maybe i915_gem_reset_prepare_engine and
i915_gem_reset_finish_engine.
-Chris


More information about the Intel-gfx mailing list