[Intel-gfx] [PATCH v2 4/5] drm/i915/selftests: Hold the rpm wakeref for the reset tests
Mika Kuoppala
mika.kuoppala at linux.intel.com
Mon Oct 9 11:50:25 UTC 2017
Chris Wilson <chris at chris-wilson.co.uk> writes:
> The lowlevel reset functions expect the caller to be holding the rpm
> wakeref for the device access across the reset. We were not explicitly
> doing this in the sefltest, so for simplicity acquire the wakeref for
> the duration of all subtests.
>
> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> Cc: Mika Kuoppala <mika.kuoppala at linux.intel.com>
Reviewed-by: Mika Kuoppala <mika.kuoppala at linux.intel.com>
> ---
> drivers/gpu/drm/i915/selftests/intel_hangcheck.c | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/selftests/intel_hangcheck.c b/drivers/gpu/drm/i915/selftests/intel_hangcheck.c
> index 7e1bdd88eda3..71ce06680d66 100644
> --- a/drivers/gpu/drm/i915/selftests/intel_hangcheck.c
> +++ b/drivers/gpu/drm/i915/selftests/intel_hangcheck.c
> @@ -878,9 +878,16 @@ int intel_hangcheck_live_selftests(struct drm_i915_private *i915)
> SUBTEST(igt_reset_queue),
> SUBTEST(igt_handle_error),
> };
> + int err;
>
> if (!intel_has_gpu_reset(i915))
> return 0;
>
> - return i915_subtests(tests, i915);
> + intel_runtime_pm_get(i915);
> +
> + err = i915_subtests(tests, i915);
> +
> + intel_runtime_pm_put(i915);
> +
> + return err;
> }
> --
> 2.14.2
More information about the Intel-gfx
mailing list