[Intel-gfx] [PATCH i-g-t] tests/kms_sequence: Add tests for new CRTC get/queue sequence ioctls

Dave Airlie airlied at gmail.com
Tue Oct 10 06:46:16 UTC 2017


On 2 October 2017 at 21:13, Petri Latvala <petri.latvala at intel.com> wrote:
> On Sat, Sep 30, 2017 at 12:35:33PM -0700, keithp at keithp.com wrote:
>> From: Keith Packard <keithp at keithp.com>
>>
>> These ioctls replace drmWaitVBlank and add ns time resolution and
>> 64-bit sequence numbers to comply with the Vulkan API specifications.
>>
>> The tests were derived from the existing kms_vblank tests with the
>> 'wait' variant elided as the new API doesn't provide a mechanism for
>> blocking in the kernel.

Because this is a new set of ioctls, IGT doesn't require a latest
libdrm headers, we
usually add local_ version of things so we can continue to keep building.

I've done this locally and it seems to work fine.
https://cgit.freedesktop.org/~airlied/intel-gpu-tools/commit/?h=kms_sequence&id=14300a7377a0a8ce19300b7e7486d17a028d8c41

Feel free to take that and squash it in, though you should also document get
igt_output_get_driver_pipe function since you exported it as Petri suggested.

Dave.

>>
>> Signed-off-by: Keith Packard <keithp at keithp.com>
>> ---
>>  lib/igt_kms.c          |   2 +-
>>  lib/igt_kms.h          |   1 +
>>  tests/Makefile.sources |   1 +
>>  tests/kms_sequence.c   | 289 +++++++++++++++++++++++++++++++++++++++++++++++++
>>  tests/meson.build      |   1 +
>>  5 files changed, 293 insertions(+), 1 deletion(-)
>>  create mode 100644 tests/kms_sequence.c
>>
>> diff --git a/lib/igt_kms.c b/lib/igt_kms.c
>> index 7bcafc07..61ecb1f2 100644
>> --- a/lib/igt_kms.c
>> +++ b/lib/igt_kms.c
>> @@ -1983,7 +1983,7 @@ report_dup:
>>       }
>>  }
>>
>> -static igt_pipe_t *igt_output_get_driving_pipe(igt_output_t *output)
>> +igt_pipe_t *igt_output_get_driving_pipe(igt_output_t *output)
>>  {
>
>
> Some documentation for this function is in order if it's made non-static.
>
>
> --
> Petri Latvala
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx


More information about the Intel-gfx mailing list