[Intel-gfx] [PATCH] drm/i915: Silently fallback to 4k scratch

Chris Wilson chris at chris-wilson.co.uk
Tue Oct 10 11:48:20 UTC 2017


Quoting Joonas Lahtinen (2017-10-10 12:30:17)
> On Tue, 2017-10-10 at 12:10 +0100, Chris Wilson wrote:
> > If we fail to allocate a 64k hugepage for scratch, we try again with a
> > normal 4k page (with some loss of efficiency at runtime). As we handle
> > this gracefully, we do not need a noisy allocation failure warning.
> > 
> > Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> > Cc: Matthew Auld <matthew.william.auld at gmail.com>
> > Cc: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>
> 
> Do we want to maybe add a DRM_INFO to else branch?

What do you want the user to do? Shutdown firefox and start again?

Maybe debug, but then what do you expect us to do?

The ultimate aide would be a diagnostic for slow runtime, for that we
could do with a tracepoint to tell us how each binding went (page_sizes
vs sg_sizes).
-Chris


More information about the Intel-gfx mailing list