[Intel-gfx] [PATCH] i-g-t/tests: Drop gem_seqno_wrap, gem_pin, gem_hangcheck_forcewake

[Antonio Argenziano]

On 10/10/17 13:19, Chris Wilson wrote:
> Quoting Antonio Argenziano (2017-10-10 18:12:17)
>>
>>
>> On 10/10/17 01:55, Abdiel Janulgue wrote:
>>> This improves the GEM tests section of I-G-T to make it more
>>> suitable for CI testing
>>
>> Can you provide a little more details on what is the rationale behind
>> this choice. Are the tests being removed only because they do not fit
>> the CI guidelines or is it because they do not offer any valuable coverage?
> 
> Hear, hear.
> 
> gem_seqno_wrap is defunct as the debug API withered away. The
> handling of wraparound under many different workloads is tested by
> gem_exec_whisper. The intention is to may seqno wrap handling a
> kselftest. That hasn't happened yet, gem_exec_whisper is not run wholy
> by CI, but nevertheless gem_seqno_wrap is still defunct.
> 
> gem_pin is a useful ABI I still shed a tear over. But it's time has
> passed and it's not coming back.
> 
> gem_hangcheck_forcewake has been superseded by drv_hangman, and a lot of
> other very extensive hangchecking that is not run by CI. Something about
> hang testing taking longer than the sun to go nova, and still will never
> be completely reliable...
> -Chris
> 

Thanks for the explanation Chris.

This convinces me more that the commit needs to be split into three 
separate patches. One for each test with an explanation of why it goes away.

-Antonio