[Intel-gfx] [PATCH 2/2] drm/i915: Allow PCH platforms fall back to BIOS LVDS mode

Chris Wilson chris at chris-wilson.co.uk
Wed Oct 11 18:06:45 UTC 2017


Quoting Ville Syrjala (2017-10-09 17:19:51)
> From: Ville Syrjälä <ville.syrjala at linux.intel.com>
> 
> With intel_encoder_current_mode() using the normal state readout code it
> actually works on PCH platforms as well. So let's nuke the PCH check from
> intel_lvds_init(). I suppose there aren't any machines that actually
> need this, but at least we get to eliminate a few lines of code, and one
> FIXME.
> 
> Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>

I have to admit the FIXME comment confused me utterly. Having read the
function, this should now work given the conversion of
intel_encoder_current_mode() to use the common encoder->get_hw_state()
routine.

Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
-Chris


More information about the Intel-gfx mailing list