[Intel-gfx] [P v4 09/11] drm/i915/uc: Unify firmware loading

[Michal Wajdeczko]

On Thu, 12 Oct 2017 11:12:23 +0200, Chris Wilson  
<chris at chris-wilson.co.uk> wrote:

> Quoting Michal Wajdeczko (2017-10-10 15:51:33)
>> Firmware loading for GuC and Huc are similar. Move common code
>> into generic function for maximum reuse.
>>

...

>> +       DRM_DEBUG_DRIVER("%s fw load %s\n",
>> +                        intel_uc_fw_type_repr(uc_fw->type),
>> +                        intel_uc_fw_status_repr(uc_fw->load_status));
>> +
>> +       DRM_ERROR("%s: Failed to load firmware %s (error %d)\n",
>> +                 intel_uc_fw_type_repr(uc_fw->type), uc_fw->path, err);
>
> It was WARN before AND NOW ITS AN ERROR! PANIC, PANIC, PANIC!
>
> I thought you were aiming to present a clear and consistent message to
> the user :)

Final failure of fw load always was a DRM_ERROR:

DRM_ERROR("Failed to complete HuC uCode load with ret %d\n", err);
in old intel_huc_init_hw() in huc.c

DRM_ERROR("GuC init failed\n")
in intel_uc_init_hw() in intel_uc.c

To be more consistent, I can downgrade above message to DRM_WARN
as this is still not normal case when valid firmware fails to load.

Based on above discussion, I think we should also fix messages in
intel_uc_init_hw and report DRM_ERROR only if Guc was "required".

Michal